fix(Steam): add better login persistence and update API version #16

ShadowApex · 2024-12-22T04:37:31Z

No description provided.

core/steam_client.gd

hphilm · 2024-12-22T11:57:56Z

core/library_steam.gd

 	item.provider_app_id = app_id
 	item.name = data["name"]
 	item.command = "steam"
-	item.args = ["-gamepadui", "-steamos3", "-steampal", "-steamdeck", "-silent", "steam://rungameid/" + app_id]


I think this change creates issues with Steam. I have no focus on the game, but on a black window and there is no controls. When I use the official stable release the games I tested work. MH Rise Demo and Pixel Gun 3D. Also I noticed that the UI is in BigPicture mode somehow.

reverting that change make the controls work again. Also the correct window is focused.

hphilm · 2025-05-15T19:19:02Z

Any progress on this one? @ShadowApex

core/library_steam.gd

pastaq · 2025-06-29T16:53:27Z

core/steam_client.gd

 var current_output: Array[String] = []

-var logger := Log.get_logger("SteamClient", Log.LEVEL.INFO)
+var logger := Log.get_logger("SteamClient", Log.LEVEL.DEBUG)


Don't forget to set back before merge

pastaq · 2025-06-29T16:54:24Z

core/steam_client.gd

 	await wait_for_network()
-
+
+	# Ensure the client is part of the Steam Deck beta


I have found different behavior depending on whether or not the Steam client is using the Steam Deck branch or not.

I think this is more about the beta channel than if the UX for the deck is used. Based on license agreements for non steamos only the flag gamepadui should be used. However BigPicture mode still acts different than when the UX for the Steamdeck is used. There is still the hope of getting an universal handheld mode and the flag for the deck may get reduced to branding purposes. However that needs further discussions with Valve.

There has been a difference, specifically when using the -steamos3 and -steamdeck flags, but lately I have been having some decent success just using the -gamepadui flag, so it's possible that using the Steam Deck channel may not be necessary.

core/steam_client.gd

pastaq · 2025-06-29T17:03:25Z

core/steam_client.gd

+		else:
+			users = vdf.data
+
+	for username in accounts.keys():


Are there two formats?

I'm not sure what you mean here. Could you elaborate?

It seems this changes the case from PascalCase to lower case sometimes?

core/steam_client.gd

pastaq · 2025-06-30T08:04:29Z

core/steam_client.gd

 var current_output: Array[String] = []

-var logger := Log.get_logger("SteamClient", Log.LEVEL.INFO)
+var logger := Log.get_logger("SteamClient", Log.LEVEL.DEBUG)


pastaq · 2025-06-30T08:19:09Z

Fixes ShadowBlip/OpenGamepadUI#298
Fixes #10

pastaq · 2025-08-08T10:37:52Z

core/library_steam.gd

 		if not item.provider_app_id.is_valid_int():
 			return
+		if not _steam.is_logged_in:
+			return


Should this produce a notification window?

pastaq · 2025-08-08T10:41:01Z

core/library_steam.gd

 ## Hook to execute when the app exits. This will try to restore the startup video.
 class ExitHook extends  AppLifecycleHook:
 	var _steam: SteamClient
+	var _replace_intro_video: bool


Can the duplicated properties and functionality be added to the parent class, or a new intermediate SteamLifecycleHook?

pastaq · 2025-08-08T10:43:40Z

core/steam_client.gd

 ## [InteractiveProcess] to spawn steamcmd in a psuedo terminal to read and write 
 ## to its stdout/stdin.

+const steam_url := "https://steamdeck-packages.steamos.cloud/archlinux-mirror/jupiter-main/os/x86_64/steam-jupiter-stable-1.0.0.81-2.5-x86_64.pkg.tar.zst"


This seems fragile, perhaps it would be better to find the highest version available in the webdir?

pastaq · 2025-08-08T10:44:53Z

core/steam_client.gd

-		DirAccess.make_dir_recursive_absolute(package_path)
-		var f := FileAccess.open(beta_file, FileAccess.WRITE)
-		f.store_string("steamdeck_publicbeta")
+	#var beta_file := "/".join([package_path, "beta"])


There seems to be a lot of dead/commented code here.

ShadowApex force-pushed the shadowapex/login-improvements branch from f4ff567 to d0851d9 Compare December 22, 2024 04:45

pastaq reviewed Dec 22, 2024

View reviewed changes

core/steam_client.gd Show resolved Hide resolved

hphilm mentioned this pull request Dec 22, 2024

Download Steam when not provided by OS or user didn't install yet #13

Open

hphilm reviewed Dec 22, 2024

View reviewed changes

ShadowApex force-pushed the shadowapex/login-improvements branch from d0851d9 to 34c1773 Compare January 17, 2025 08:05

fix(Steam): add better login persistence and update API version

590eaf7

ShadowApex force-pushed the shadowapex/login-improvements branch from 34c1773 to 590eaf7 Compare April 12, 2025 17:15

pastaq reviewed Jun 29, 2025

View reviewed changes

core/library_steam.gd Show resolved Hide resolved

pastaq reviewed Jun 29, 2025

View reviewed changes

core/library_steam.gd Outdated Show resolved Hide resolved

pastaq reviewed Jun 29, 2025

View reviewed changes

core/steam_client.gd Outdated Show resolved Hide resolved

pastaq reviewed Jun 29, 2025

View reviewed changes

core/steam_client.gd Show resolved Hide resolved

ShadowApex force-pushed the shadowapex/login-improvements branch 3 times, most recently from 3e5f69b to 9ca2f8b Compare June 30, 2025 04:09

fix(Steam): add lifecycle hooks, better OOTBE, and remove thread pool

04040df

ShadowApex force-pushed the shadowapex/login-improvements branch from 9ca2f8b to 04040df Compare June 30, 2025 05:35

pastaq requested changes Jun 30, 2025

View reviewed changes

hphilm mentioned this pull request Jul 20, 2025

feat(Launch): add app lifecycle implementation and better handling of steam ShadowBlip/OpenGamepadUI#470

Merged

pastaq reviewed Aug 8, 2025

View reviewed changes

ShadowApex marked this pull request as draft August 12, 2025 02:59

fix(Steam): add better install hooks and progress

2b476d8

ShadowApex force-pushed the shadowapex/login-improvements branch from 7f63ab1 to 2b476d8 Compare September 22, 2025 04:17

		await wait_for_network()


		# Ensure the client is part of the Steam Deck beta

fix(Steam): add better login persistence and update API version #16

Are you sure you want to change the base?

fix(Steam): add better login persistence and update API version #16

Uh oh!

Conversation

ShadowApex commented Dec 22, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hphilm commented May 15, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pastaq commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pastaq commented Jun 30, 2025 •

edited

Loading